feat(sourcemaps): add SentryFacade and Sentry CLI Boilerplate #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
force-pushed
the
lms-upload-sourcemaps
branch
from
7c5da41 to
4956ee5
Compare
vladanpaunovic
approved these changes
Aug 22, 2022
Contributor
vladanpaunovic
left a comment
vladanpaunovic
left a comment
There was a problem hiding this comment.
+1 for the idea of getting rid of sentry-cli later on
While it is hard to make a call on this PR as it seems like a WIP, I like the direction it is going so ✅ from me
vladanpaunovic
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks the first step towards getting source maps and release creation/finalization working. It adds Sentry-CLI as a dependency, as well as a facade object for the necessary steps (see explanation below).
While we want to get rid of depending on Sentry CLI eventually, I decided to use it for now to get our MVP out faster. To replace Sentry CLI functionality easily with our "native" functionality later, I created a facade to abstract the implementation of the necessary steps from what we call in the "front end" of our plugin. We can replace each CLI command step by step with our own implementation later on.
Furthermore, I added a few fields to
Options+ a bunch of commented out ones from the webpack plugin and I moved the type definition to a newtypes.tsfileNext up: Implement CLI calls to:
There are more CLI calls in the webpack plugin (clear artifacts, set commits, add deploy) but we don't necessarily have to add them to the MVP.